Type-stable multidimensional FFTs for different plan and array dims#115
Merged
dannys4 merged 10 commits intoJuliaMath:mainfrom Apr 6, 2026
Merged
Type-stable multidimensional FFTs for different plan and array dims#115dannys4 merged 10 commits intoJuliaMath:mainfrom
dannys4 merged 10 commits intoJuliaMath:mainfrom
Conversation
Val(dim) fix check
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
==========================================
- Coverage 98.85% 98.76% -0.09%
==========================================
Files 4 4
Lines 526 569 +43
==========================================
+ Hits 520 562 +42
- Misses 6 7 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sort copy rename region for type stability
dannys4
approved these changes
Apr 6, 2026
Collaborator
dannys4
left a comment
dannys4
left a comment
There was a problem hiding this comment.
Looks like the only lines codecov says you miss are with macros, which always mess up.
Collaborator
|
Sorry for super late review, digging out of conference backlog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My comment that this can't be type-stable was a bit premature in hindsight. Also, fixed up a few checks.
One question: should the generated parts be pulled out and
@noinline/@nospecialized to reduce redundant compilation for different plan dimensions?P.S. now that the basic ND complex FFTs are done, I wonder if it might be fun if anyone here with a subscription can unleash Claude Pro (or Max?) to follow up and sort of copy the same style to finish this up for real FFTs? since it's pretty much just (B)RFFTing the first dimension then repeating the multidimensional FFT on the others.
(mostly curious because I couldn't wrangle the free tier into doing this...)